Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): trim cli-util crate deps #9410

Merged
merged 1 commit into from
Jul 10, 2024
Merged

chore(deps): trim cli-util crate deps #9410

merged 1 commit into from
Jul 10, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 9, 2024

we can get rid of a few things

@mattsse mattsse requested review from onbjerg and gakonst as code owners July 9, 2024 20:00
@mattsse mattsse added A-dependencies Pull requests or issues that are about dependencies A-cli Related to the reth CLI labels Jul 9, 2024
@mattsse mattsse requested a review from joshieDo July 9, 2024 20:00
Rjected
Rjected approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yep, pulling in network just for that method is def too much

@mattsse mattsse added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit ce20adc Jul 10, 2024
34 checks passed
@mattsse mattsse deleted the matt/trim-cli-util-deps branch July 10, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo

Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @Rjected @rkrasiuk